Bug 295704
| Summary: | Unnecessary calls to hasAvailableFrameCallback | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
Currently, hasAvailableFrameCallback is called whenever we render a frame on screen with no exception.
This callback is used for two purposes:
1- Let the MediaPlayerPrivate knows that the first frame has been decoded and rendered
2- When gathering frame metadata due to a call to requestVideoFrameCallback
1- is only required once after a flush
2- is only required if the JS has used requestVideoFrameCallback API.
We could optimise the code to only call hasAvailableFrameCallback when needed only.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/47820
Jean-Yves Avenard [:jya]
rdar://155519872
EWS
Committed 297330@main (d392a868cc16): <https://commits.webkit.org/297330@main>
Reviewed commits have been landed. Closing PR #47820 and removing active labels.