Bug 29535

Summary:

[Qt] Buildfix on Windows building with MSVC

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

zoltan

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
proposed patch	none
proposed patch	none

Csaba Osztrogonác

Reported 2009-09-21 00:18:59 PDT

The error message: ..\..\..\JavaScriptCore\wtf/Vector.h(276) : warning C4003: not enough actual parameters for macro 'max' t:\webkit_git\javascriptcore\wtf\HashTraits.h(72) : warning C4003: not enough actual parameters for macro 'max' t:\webkit_git\javascriptcore\wtf\HashTraits.h(73) : warning C4003: not enough actual parameters for macro 'max' t:\webkit_git\javascriptcore\wtf\HashTraits.h(74) : warning C4003: not enough actual parameters for macro 'max' ..\..\..\JavaScriptCore\runtime/UString.h(93) : warning C4003: not enough actual parameters for macro 'max' ..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2589: '(' : illegal token on right side of '::' ..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2059: syntax error : '::' ..\..\..\JavaScriptCore\runtime/UString.h(93) : error C2143: syntax error : missing ';' before '{' ..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : warning C4003: not enough actual parameters for macro 'max' ..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : error C2589: '(' : illegal token on right side of '::' ..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(60) : error C2059: syntax error : '::' ..\..\..\JavaScriptCore\jit\ExecutableAllocator.h(61) : error C2143: syntax error : missing ';' before '{' QNetworkReplyHandler.cpp Build error caused by define max(a,b) in a standard windows header (WinDef.h). Here max function must be used instead of max macro, accordingly max macro shouldn't be defined here. ( std::numeric_limits<T>::max() , ... )

Attachments
proposed patch (924 bytes, patch) 2009-09-21 00:20 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
proposed patch (948 bytes, patch) 2009-09-21 07:54 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2009-09-21 00:20:51 PDT

Created attachment 39841 [details] proposed patch

Csaba Osztrogonác

Comment 2 2009-09-21 07:54:52 PDT

Created attachment 39851 [details] proposed patch Simon Hausmann pointed to missing include config.h . I tried it, and works correctly. Here is the simpler patch.

Zoltan Horvath

Comment 3 2009-09-21 08:50:20 PDT

Landed in http://trac.webkit.org/changeset/48583

Note You need to log in before you can comment on or make changes to this bug.