Bug 295252
| Summary: | [WPE] Click count leaking through successive layout test within the same WPEView | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WPE WebKit | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
In the new WPE Platform, `WPEWebView` tracks the click count in its `priv->lastButtonPress` to forward to WebKit when processing incoming button presses. This click count can leak through tests when the same WPEWebView is fed events by EventSenderProxyClientWPE.
For example, the tests fast/html/details-remove-summary-X-and-click.html just removes an element from the DOM and makes a single mouseMove+mousePress+mouseUp operation in successive separate test files. For the first test, wpe ended the expectation with the correct "caret:" entry, and for subsequent tests, we could end up with a "selection start:" and "selection end:" pair and an emitted mouse double click. And, if running in isolation, we get the "caret:" instead.
Tentative patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Fix: WPEView, not WebView
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/47417
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/47813
EWS
Committed 297259@main (95499dad0adf): <https://commits.webkit.org/297259@main>
Reviewed commits have been landed. Closing PR #47813 and removing active labels.