Bug 295215
| Summary: | Fix inheritance of type compactness in TZone type specification | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | bmalloc | Assignee: | David Degazio <d_degazio> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 295550 | ||
| Bug Blocks: | |||
David Degazio
TZone types currently track whether or not that type is compact-allocated, but this is based solely on whether the type was annotated with a compact or non-compact macro. Really, we want compactness to be inherited, so that if any class in an annotated type's hierarchy needs to support compact pointers, the derived type also must support compact pointers. This is currently respected in allocation logic, so we just need to also check requiresCompactPointers<T>() for the type when initializing the specification so everything is consistent.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/154691668>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/47390
EWS
Committed 296878@main (2cf886ecf010): <https://commits.webkit.org/296878@main>
Reviewed commits have been landed. Closing PR #47390 and removing active labels.
David Degazio
Reopened Bugzilla.
Revert 296878@main due to apparent WebView regression, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=295550.