Bug 295185
| Summary: | [WebKitSwift] Some files within the module unnecessarily import itself | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Abrar Rahman Protyasha <a_protyasha> |
| Component: | New Bugs | Assignee: | Abrar Rahman Protyasha <a_protyasha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | a_protyasha, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Abrar Rahman Protyasha
`import WebKitSwift` from files under `Source/WebKit/WebKitSwift/` is redundant, so let's drop that.
```
Source/WebKit/WebKitSwift/IdentityDocumentServices/ISO18013MobileDocumentRequest+Extras.swift:28:8: warning: file 'ISO18013MobileDocumentRequest+Extras.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentController.swift:29:8: warning: file 'WKIdentityDocumentPresentmentController.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentMobileDocumentRequest+Extras.swift:28:8: warning: file 'WKIdentityDocumentPresentmentMobileDocumentRequest+Extras.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentMobileDocumentRequest.swift:28:8: warning: file 'WKIdentityDocumentPresentmentMobileDocumentRequest.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentRawRequest.swift:27:8: warning: file 'WKIdentityDocumentPresentmentRawRequest.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentRequest.swift:27:8: warning: file 'WKIdentityDocumentPresentmentRequest.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentResponse.swift:27:8: warning: file 'WKIdentityDocumentPresentmentResponse.swift' is part of module 'WebKitSwift'; ignoring import
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentRawRequestValidator.swift:28:8: warning: file 'WKIdentityDocumentRawRequestValidator.swift' is part of module 'WebKitSwift'; ignoring import
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/154631961>
Abrar Rahman Protyasha
Pull request: https://github.com/WebKit/WebKit/pull/47360
EWS
Committed 296812@main (3c41afd934ce): <https://commits.webkit.org/296812@main>
Reviewed commits have been landed. Closing PR #47360 and removing active labels.