Bug 294824
| Summary: | [WebDriver][BiDi] Fix error forwarding for errors with detail string | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
Currently, if we return an error message with a detail string, `WebDriverBiDiProcessor::sendBidiMessage` returns "UnknownError" with the payload being the exception error, a ";", and the detail string. This is happening because we don't split the incoming internal error message if we have the ";" separator.
This is happening, for example, when we use something like `callback(makeUnexpected(STRING_FOR_PREDEFINED_ERROR_NAME_AND_DETAILS(InvalidParameter, "Subscription ID must be a valid string."_s)));`
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/47044
Radar WebKit Bug Importer
<rdar://problem/154639388>
EWS
Committed 299108@main (f8c41ac3bcf6): <https://commits.webkit.org/299108@main>
Reviewed commits have been landed. Closing PR #47044 and removing active labels.