Bug 294199 – Fix computed value for `-webkit-text-stroke`

• Component: CSS
• Status: NEW

[Ahmad Saleem]

Hi Team,

While syncing `css-fill-stroke` directory from WPT upstream here - https://github.com/WebKit/WebKit/pull/46490

It seems we fail following WPT case:

Test Case: https://wpt.fyi/results/css/css-fill-stroke/webkit-text-stroke-computed.html?label=experimental&label=master&aligned

Test Case Live Link: http://wpt.live/css/css-fill-stroke/webkit-text-stroke-computed.html

Chrome and Firefox passes above, so it would be good to align and fix.

Thanks!

[Ahmad Saleem]

Might be - https://searchfox.org/wubkat/source/Source/WebCore/css/CSSProperties.json#11137

"-webkit-text-stroke": {
            "inherited": true,
            "codegen-properties": {
                "longhands": [
                    "-webkit-text-stroke-width",
                    "-webkit-text-stroke-color"
                ],
                "skip-style-extractor": true,
                "skip-style-extractor-comment": "FIXME: Figure out and document why this has no computed value",
                "shorthand-pattern": "StandardSpaceSeparated",
                "parser-grammar-unused": "<'-webkit-text-stroke-width'> || <'-webkit-text-stroke-color'>",
                "parser-grammar-unused-reason": "Needs support for shorthand grammars."
            },
            "status": "non-standard"
        },

Web Specification - https://compat.spec.whatwg.org/#the-webkit-text-stroke

[Ahmad Saleem]

I tried removing these two lines:

               "skip-style-extractor": true,
                "skip-style-extractor-comment": "FIXME: Figure out and document why this has no computed value",

but it didn't compile, so might need something more.

[Radar WebKit Bug Importer]

<rdar://problem/153513724>