Summary: | Byte alignment issue on MIPS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, darin, diegohcg, eric, hausmann, kent.hansen, morrita, plaes, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Tor Arne Vestbø
2009-09-18 07:36:34 PDT
The OS should be Other in this bug This is not a Qt-specific issue. +1 for adding CPU(MIPS) to the "going 4 bytes at a time is unsafe" condition, though. Created attachment 51602 [details]
Aligment patch from Gentoo for ARM, SPARC and SH4 platforms
This is the patch we are using on Gentoo to fix alignment issues on SPARC and SH4 platforms.
Removing Qt keyword and Qt from the title, this is not a Qt specific issue. (In reply to comment #3) > Created an attachment (id=51602) [details] > Aligment patch from Gentoo for ARM, SPARC and SH4 platforms > > This is the patch we are using on Gentoo to fix alignment issues on SPARC and > SH4 platforms. Priit, can you submit your patch with ChangeLog, diffed against tip of tree and with review? set? See also http://webkit.org/coding/contributing.html Thanks :) Created attachment 63668 [details]
Access one byte at a time for MIPS
To fix this issue, we follow ARM and SH4 to access one byte at a time.
This improves the performance on MIPS, due to no kernel involvement to fix unaligned accesses.
In the future, we still can use lwl/lwr to improve the performance. Thanks!
Regards,
Chao-ying
Look really a trivial and small change. Anyone who has MIPS experience is looks good candidate for just giving r+. Comment on attachment 63668 [details]
Access one byte at a time for MIPS
r=me
Comment on attachment 63668 [details] Access one byte at a time for MIPS Clearing flags on attachment: 63668 Committed r66205: <http://trac.webkit.org/changeset/66205> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/66205 might have broken Qt Linux Release Maybe we should reverse this check. Maintaining list of platforms that allow unaligned access might be better than a list of platforms that do not. |