Bug 293988
| Summary: | Allow constructing a `RefPtr<T>` from a `T&` instead of requiring a `T*` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
I think this makes sense as we already allow constructing a `RefPtr<T>` from a `Ref<T>&&`, and a `WeakPtr<T>` from a `T&`. This makes our code a little nicer and this avoids having the RefPtr constructor do a null check that is unnecessary (though the compiler hopefully optimizes it out).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/46284
EWS
Committed 295794@main (c0596157ce8f): <https://commits.webkit.org/295794@main>
Reviewed commits have been landed. Closing PR #46284 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/152555009>