Bug 293920
| Summary: | Determining that a character is Arabic may be wrong | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Gower <i_gower> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | webkit-bug-importer |
| Priority: | P4 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ian Gower
Uploading bug for past Radar: rdar://6677040
* SUMMARY
In UnicodeIcu.h, this function:
inline bool isArabicChar(UChar32 c)
{
return ublock_getCode(c) == UBLOCK_ARABIC;
}
maybe should be using this:
uscript_getScript(c, &err) == USCRIPT_ARABIC && U_SUCCESS(err)
instead. Not every Arabic character is in the Arabic block any more, due to extensions to Unicode.
If this test is only used for compatibility shaping, then it's probably OK, as that only applies to older Arabic characters.
***Apply modification to current code located in WTF/Source/wtf/URLHelpers:
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Gower
<rdar://problem/6677040>
Ian Gower
Pull request: https://github.com/WebKit/WebKit/pull/46221
EWS
Committed 295893@main (2cafff28b06f): <https://commits.webkit.org/295893@main>
Reviewed commits have been landed. Closing PR #46221 and removing active labels.