Bug 293862
| Summary: | Fix switch-over point for implicit discrete 'to'-animations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through WPT specific failures and noticing other browser result, it seems that Blink / Chromium progressed following WPT recently:
WPT Test Case: https://wpt.fyi/results/svg/animations/animate-display-to-none-001.html?label=master&label=experimental&aligned
WPT Live Link: http://wpt.live/svg/animations/animate-display-to-none-001.html
Blink Commit: https://source.chromium.org/chromium/chromium/src/+/39d072be004bf3fc4a5f534c0d926293255ec74f
WebKit Source: https://searchfox.org/wubkat/rev/4635a5d12b4bcaf0c05d88c9e22ee9f408f09ac6/Source/WebCore/svg/properties/SVGAnimationDiscreteFunction.h#52
It is simple change as follow:
if (((m_animationMode == AnimationMode::FromTo || m_animationMode == AnimationMode::To) && progress > 0.5) || progress == 1)
and we progress above test case similar to Blink.
Just raising, so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/152376446>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/46174
EWS
Committed 295662@main (4923841d8c93): <https://commits.webkit.org/295662@main>
Reviewed commits have been landed. Closing PR #46174 and removing active labels.