Bug 293703
| Summary: | [WebDriver] Driver segfault when a pointer move or scroll action is missing a coordinate | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=290297 | ||
Lauro Moura
`WebDriverService::processPointerMoveAction`/`processWheelAction` need to validate the incoming action request for the required fields before dispatching the actions. If it fails to do so, `Session::performActions` might access the `WebDriver::Action` x and y fields directly without checking whether they're present, leading to errors like `bad_optional_access`.
Related WPT tests:
imported/w3c/webdriver/tests/classic/perform_actions/pointer_mouse.py::test_missing_coordinates[x]
imported/w3c/webdriver/tests/classic/perform_actions/pointer_mouse.py::test_missing_coordinates[y]
imported/w3c/webdriver/tests/classic/perform_actions/invalid.py::test_wheel_action_scroll_missing_property[x]
imported/w3c/webdriver/tests/classic/perform_actions/invalid.py::test_wheel_action_scroll_missing_property[y]
imported/w3c/webdriver/tests/classic/perform_actions/invalid.py::test_wheel_action_scroll_missing_property[deltaX]
imported/w3c/webdriver/tests/classic/perform_actions/invalid.py::test_wheel_action_scroll_missing_property[deltaY]
Patch incoming, alongside other small related scroll invalid type fixes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/46014
Lauro Moura
*** Bug 290297 has been marked as a duplicate of this bug. ***
EWS
Committed 295789@main (80ff32d5e1ae): <https://commits.webkit.org/295789@main>
Reviewed commits have been landed. Closing PR #46014 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/152545957>