Bug 29366 – REGRESSION: formatting is broken in console.log()

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Yury Semikhatsky]

Template parameters are not substituted in console.log():

Steps:
1) In the error console type  evaluate
console.log('s=%s', 'a string');
2) Look at the output.

[Yury Semikhatsky]

Created attachment 39761 [details]
patch

[Timothy Hatcher]

Comment on attachment 39761 [details]
patch

> +        if (typeof substitution == 'object' && Object.proxyType(substitution) == 'number') {
> +            substitution = substitution.description;
> +        }

Use === here. Also remove the braces.


> +        if (typeof substitution == 'object' && Object.proxyType(substitution) == 'number') {
> +            substitution = substitution.description;
> +        }

Ditto.


> +        if (typeof substitution == 'object' && Object.proxyType(substitution) != 'null') {
> +            substitution = substitution.description;
> +        }

Ditto.

Will r+ when those style changes are made.

[Yury Semikhatsky]

Created attachment 39763 [details]
patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 39761 [details])
> > +        if (typeof substitution == 'object' && Object.proxyType(substitution) == 'number') {
> > +            substitution = substitution.description;
> > +        }
> 
> Use === here. Also remove the braces.
> 
Done.

> 
> > +        if (typeof substitution == 'object' && Object.proxyType(substitution) == 'number') {
> > +            substitution = substitution.description;
> > +        }
> 
> Ditto.
> 
Done.

> 
> > +        if (typeof substitution == 'object' && Object.proxyType(substitution) != 'null') {
> > +            substitution = substitution.description;
> > +        }
> 
> Ditto.
> 
> Will r+ when those style changes are made.
Done.

[Timothy Hatcher]

Comment on attachment 39763 [details]
patch

You still have the braces. Also you should use double quotes for stings.

[Yury Semikhatsky]

Created attachment 39776 [details]
patch

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 39763 [details])
> You still have the braces.
FIxed.

> Also you should use double quotes for stings.
Done.

[Eric Seidel (no email)]

Comment on attachment 39776 [details]
patch

AFAIK, Yury is not a committer, and I don't believe this patch will break Chromium, so setting commit-queue+.

Yury, if you would like reviewers to set cq+ for you, you should set cq=?.  Or if you have special plans for your patches and don't want them landed automatically, please set cq-.  As-is, I'm just going to go off the assumption that you want this landed normally, but can't because you're not a committer, so I'm cq+'ing it for you.

[WebKit Commit Bot]

Comment on attachment 39776 [details]
patch

Rejecting patch 39776 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
Merge conflict during commit: Your file or directory 'WebCore/ChangeLog' is probably out-of-date: resource out of date; try updating at /usr/local/libexec/git-core//git-svn line 469

[Eric Seidel (no email)]

Comment on attachment 39776 [details]
patch

Sorry.  bug 28316, will fix.

[WebKit Commit Bot]

Comment on attachment 39776 [details]
patch

Clearing flags on attachment: 39776

Committed r48536: <http://trac.webkit.org/changeset/48536>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Yury Semikhatsky]

(In reply to comment #8)
> (From update of attachment 39776 [details])
> AFAIK, Yury is not a committer, and I don't believe this patch will break
> Chromium, so setting commit-queue+.
> 
> Yury, if you would like reviewers to set cq+ for you, you should set cq=?. 
OK, will do next time. I didn't know I need to do something in order my patches get to the commit-queue. Now I see it described in  http://webkit.org/coding/contributing.html. Thanks for your advices!