Bug 293606
| Summary: | [WPE] WPE Platform: remove circular dependency between WPEView and WPEBuffer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WPE WebKit | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
WPEBuffer keeps a reference to a WPEView and it's very common in WPEView implementations to keep a reference of the buffer in use. The WPEBuffer doesn't really need the view, in most of the cases it's only used to get the display. So, we can change the view property by display and use a weak reference instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/45936
EWS
Committed 295435@main (5264807369a3): <https://commits.webkit.org/295435@main>
Reviewed commits have been landed. Closing PR #45936 and removing active labels.