Bug 293504
| Summary: | Web Inspector: Rebaseline test results after 293715@main dropped implicit NSString conversion | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | Web Inspector | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
Since 293715@main, a number of inspector tests are failing with errors like:
--- JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2025-04-16 21:00:43.374656275 -0300
+++ /tmp/tmp94ozji_t/type-requiring-runtime-casts.json-result 2025-05-23 17:00:51.401103074 -0300
@@ -1503,7 +1503,7 @@
- (void)setAnimals:(TestProtocolTestCastedAnimals)animals
{
- [super setString:toProtocolString(animals) forKey:@"animals"];
+ [super setString:toProtocolString(animals).createNSString().get() forKey:@"animals"];
}
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/45851
EWS
Committed 295378@main (c808d8343a5a): <https://commits.webkit.org/295378@main>
Reviewed commits have been landed. Closing PR #45851 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/151957050>