Bug 293422
| Summary: | VideoMediaSampleRenderer can enqueue sample with a presentation time lower than the last calculated minimum time | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
To determine the minimum upcoming sample time, the VideoMediaSampleRenderer look into the incoming compressed sample.
In the case where decoding is happening faster than how fast the SourceBufferPrivate can enqueue frame, we may incorrectly calculate the minimum upcoming frame time.
We should simplify this code and let the SourceBufferPrivate pass this information to the VideoMediaSampleRenderer as it contains the ultimate source of truth.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/151850145>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/45832
EWS
Committed 295388@main (b15a127ad263): <https://commits.webkit.org/295388@main>
Reviewed commits have been landed. Closing PR #45832 and removing active labels.