Bug 29326

Summary: On Leopard, media element can't handle audio/mp4 MIME type in source tag
Product: WebKit Reporter: David Gatwood <dgatwood>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cyberskull, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 40829    
Attachments:
Description Flags
proposed patch
mitz: review+
revised patch simon.fraser: review+

David Gatwood
Reported 2009-09-16 21:55:50 PDT
This block of code works only if you remove the type attribute from the first source tag. By my reading of RFC 4337, that's a completely valid MIME type to use for MPEG 4 audio. It works with audio/mpeg, but that seems like a bit of a hack. <audio id="aud_01" controls="true" width="200" height="60" > <source src="http://images.gatwood.net/gatwood.net/music/Cinderella%20Suite.m4a" type="audio/mp4" media="screen"></source> <source src="http://images.gatwood.net/gatwood.net/music/Cinderella%20Suite.ogg" type="audio/ogg" media="screen"></source> <embed id="mov_01" src="http://images.gatwood.net/gatwood.net/music/Cinderella%20Suite.m4a" autostart=false height="60"></embed> </audio> See http://www.rfc-editor.org/rfc/rfc4337.txt
Attachments
proposed patch (7.97 KB, patch)
2010-07-13 10:44 PDT, Eric Carlson 		mitz: review+
DetailsFormatted DiffDiff
revised patch (7.98 KB, patch)
2010-07-13 10:50 PDT, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Gatwood
Comment 1 2009-09-16 21:56:24 PDT
This is actually in Safari 4.0.3, but that version isn't in the version list.
Trevor Downs
Comment 2 2010-07-06 19:20:19 PDT
I'm getting the same bug in WebKit 533 (Safari 5) as well.
Trevor Downs
Comment 3 2010-07-06 19:20:47 PDT
(In reply to comment #2) > I'm getting the same bug in WebKit 533 (Safari 5) as well. Oh: Mac OS X 10.5.8 PPC.
Eric Carlson
Comment 4 2010-07-06 20:40:20 PDT
This works correctly on 10.6.4, I wonder if UTI doesn't include "audio/mp4" on Leopard?
Trevor Downs
Comment 5 2010-07-07 08:04:24 PDT
(In reply to comment #4) > This works correctly on 10.6.4, I wonder if UTI doesn't include "audio/mp4" on Leopard? Where would I look in 10.5 to confirm this?
Eric Carlson
Comment 6 2010-07-13 10:44:07 PDT
Created attachment 61395 [details] proposed patch
Eric Carlson
Comment 7 2010-07-13 10:50:18 PDT
Created attachment 61396 [details] revised patch
Eric Carlson
Comment 8 2010-07-13 13:16:54 PDT
http://trac.webkit.org/changeset/63239
Note You need to log in before you can comment on or make changes to this bug.