Bug 29321

Summary: Post the WebViewDidChangeSelectionNotification when text selection changes
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit APIAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
Patch
sullivan: review+
Updated patch aroben: review+

Ada Chan
Reported 2009-09-16 17:32:22 PDT
IWebEditingDelegate::webViewDidChangeSelection() should be called when any text selection changes inside a WebView. The Mac code already posts a WebViewDidChangeSelectionNotification when text selection changes.
Attachments
Patch (2.18 KB, patch)
2009-09-17 10:33 PDT, Ada Chan 		sullivan: review+
DetailsFormatted DiffDiff
Updated patch (2.16 KB, patch)
2009-09-17 11:22 PDT, Ada Chan 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2009-09-17 10:33:36 PDT
Created attachment 39705 [details] Patch
Ada Chan
Comment 2 2009-09-17 10:57:25 PDT
After further discussion with Adam Roben, we have agreed that it might be better to just post the WebViewDidChangeSelectionNotification instead of using IWebEditingDelegate.
Ada Chan
Comment 3 2009-09-17 11:22:50 PDT
Created attachment 39709 [details] Updated patch
Adam Roben (:aroben)
Comment 4 2009-09-17 11:25:30 PDT
Comment on attachment 39709 [details] Updated patch > Index: WebKit/win/Interfaces/IWebEditingDelegate.idl > =================================================================== > --- WebKit/win/Interfaces/IWebEditingDelegate.idl (revision 48477) > +++ WebKit/win/Interfaces/IWebEditingDelegate.idl (working copy) > @@ -23,6 +23,8 @@ > * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > +cpp_quote("#define WebViewDidChangeSelectionNotification TEXT(\"WebViewDidChangeSelectionNotification\")") > + I'd put this in IWebView.idl, to match where it is defined in the Mac API. r=me
Ada Chan
Comment 5 2009-09-17 11:32:55 PDT
Fixed in r48478
Note You need to log in before you can comment on or make changes to this bug.