Bug 293178
| Summary: | [GStreamer] Build with telemetry enabled and without EME enabled broken | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <philn> |
| Component: | Platform | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
MediaPlayerPrivateGStreamer::getDrm() makes use of CDMInstance which is guarded by EME ifdefs...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
In file included from /var/home/phil/WebKit/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-55.cpp:6:
/var/home/phil/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:4575:38: error: member access into incomplete type 'const CDMInstance'
4575 | String keySystem = drmCdmInstance->keySystem();
| ^
/var/home/phil/WebKit/Source/WebCore/platform/graphics/MediaPlayer.h:91:7: note: forward declaration of 'WebCore::CDMInstance'
91 | class CDMInstance;
| ^
In file included from /var/home/phil/WebKit/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-55.cpp:6:
/var/home/phil/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:4576:9: error: use of undeclared identifier 'GStreamerEMEUtilities'
4576 | if (GStreamerEMEUtilities::isPlayReadyKeySystem(keySystem))
| ^
/var/home/phil/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:4578:9: error: use of undeclared identifier 'GStreamerEMEUtilities'
4578 | if (GStreamerEMEUtilities::isWidevineKeySystem(keySystem))
| ^
3 errors generated.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/45546
EWS
Committed 295098@main (2e5025806601): <https://commits.webkit.org/295098@main>
Reviewed commits have been landed. Closing PR #45546 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/151611628>