Bug 29317

Summary: PrettyPatch displays last two lines of a git-format-patch diff strangely
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, cmarcelo, commit-queue, dbates, ddkilzer, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: https://bugs.webkit.org/attachment.cgi?id=39615&action=prettypatch
Attachments:
Description Flags
patch none

Description Eric Seidel (no email) 2009-09-16 15:37:36 PDT 
PrettyPatch displays diff strangely

https://bugs.webkit.org/attachment.cgi?id=39615&action=prettypatch

Notice how there are no minus lines in the ChangeLog here:
https://bugs.webkit.org/attachment.cgi?id=39615

Maybe he edited the diff by hand?
Comment 1 Eric Seidel (no email) 2009-09-16 15:39:28 PDT 
Same trouble here:
https://bugs.webkit.org/attachment.cgi?id=39658&action=prettypatch

I think it might be related to git diffs.
Comment 2 Adam Roben (:aroben) 2009-09-16 16:06:32 PDT 
That's just how the last two lines of git-format-patch files always appear with PrettyPatch. The last two lines look like this:

-- 
1.6.0.4

This is certainly a bug in PrettyPatch.
Comment 3 Caio Marcelo de Oliveira Filho 2011-03-08 11:52:10 PST 
Created attachment 85071 [details]
patch
Comment 4 Caio Marcelo de Oliveira Filho 2011-03-10 12:27:26 PST 
I think this will fix bug 19963 as well.
Comment 5 WebKit Commit Bot 2011-03-10 16:06:31 PST 
Comment on attachment 85071 [details]
patch

Clearing flags on attachment: 85071

Committed r80782: <http://trac.webkit.org/changeset/80782>
Comment 6 WebKit Commit Bot 2011-03-10 16:06:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-03-10 17:33:39 PST 
http://trac.webkit.org/changeset/80782 might have broken GTK Linux 32-bit Release
Comment 8 Caio Marcelo de Oliveira Filho 2011-03-10 20:17:32 PST 
*** Bug 19963 has been marked as a duplicate of this bug. ***