Bug 292771

Summary:

Structure Heap libpas doesn't call pas_page_malloc commit

Product:

WebKit

Reporter:

Ian Grunert <ian.grunert>

Component:

bmalloc

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

dan.hecht, ggaren, keith_miller, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch validating pas_page_malloc commit is not called	none

Ian Grunert

Reported 2025-05-09 07:24:01 PDT

Created attachment 475177 [details] Patch validating pas_page_malloc commit is not called While calling pas_page_malloc commit appears to be optional on Linux + Mac, on Windows we need to commit the memory prior to accessing it. We can work around this on Windows by committing the full structure heap region - but this looks like a bug.

Attachments
Patch validating pas_page_malloc commit is not called (2.09 KB, application/mbox) 2025-05-09 07:24 PDT, Ian Grunert	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2025-05-16 07:24:12 PDT

<rdar://problem/151463092>

Yusuke Suzuki

Comment 2 2025-05-16 09:58:56 PDT

Please do not do it on macOS and Linux as it is not necessary.

Ian Grunert

Comment 3 2025-05-16 10:13:31 PDT

I put a Windows-specific workaround into https://github.com/WebKit/WebKit/pull/41945 which seems to be working. Agree that adding the call on macOS / Linux seems unnecessary for release builds. Not sure if we'd want to do this on testing builds for the PAS_MPROTECT_DECOMMITTED code path.

Note You need to log in before you can comment on or make changes to this bug.