Bug 292416
| Summary: | [GTK][WPE] Enable Cookie Store API by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, pgriffis, rupin |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=286786 https://bugs.webkit.org/show_bug.cgi?id=286189 |
||
Carlos Alberto Lopez Perez
Cookie Store API <https://wicg.github.io/cookie-store> is a web spec that is currently supported by the 3 main Web engines.
Before 289626@main it was enabled by default for Mac ports, and after that it depends on a build-time conditional macro.
I have tried to enable it for the GTK and WPE ports and I run the WPT tests (not the imported ones here in webkit, but the real WPT tests) and I got this numbers:
* WPT test results for cookie-store/ on WebKitGTK before enabling CookieStoreAPI:
web-platform-test
~~~~~~~~~~~~~~~~~
Ran 608 checks (538 subtests, 70 tests)
Expected results: 157
Unexpected results: 451
test: 7 (3 error, 4 timeout)
subtest: 444 (437 fail, 3 notrun, 4 timeout)
* WPT test results for cookie-store/ on WebKitGTK after after CookieStoreAPI:
web-platform-test
~~~~~~~~~~~~~~~~~
Ran 608 checks (538 subtests, 70 tests)
Expected results: 487
Unexpected results: 121
test: 5 (5 error)
subtest: 116 (114 fail, 2 notrun)
* WPT test results for cookie-store/ on WPE WebKit before after CookieStoreAPI:
web-platform-test
~~~~~~~~~~~~~~~~~
Ran 608 checks (538 subtests, 70 tests)
Expected results: 157
Unexpected results: 451
test: 7 (3 error, 4 timeout)
subtest: 444 (437 fail, 3 notrun, 4 timeout)
* WPT test results for cookie-store/ on WPE WebKit after after CookieStoreAPI:
web-platform-test
~~~~~~~~~~~~~~~~~
Ran 608 checks (538 subtests, 70 tests)
Expected results: 490
Unexpected results: 118
test: 2 (2 error)
subtest: 116 (114 fail, 2 notrun)
So it seems to me like we should enable this by default.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/44825
EWS
Committed 294448@main (24324208dd4d): <https://commits.webkit.org/294448@main>
Reviewed commits have been landed. Closing PR #44825 and removing active labels.