Bug 292414
| Summary: | Prevent resizing of video poster image while waiting for initial frame | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric.carlson, jean-yves.avenard, jer.noble, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While trying to do clean-up in test expectation by looking into tests which I can import from WPT, I noticed that we fail subtest in `video-size.html`:
Blink Commit: https://source.chromium.org/chromium/chromium/src/+/048c5c63908271582e4a36376d8c0e783b07523b
Test Case Expectations:
PASS no 'src' and no 'poster', with 'width' and 'height' attributes
PASS no 'src' and no 'poster', with no 'width' and 'height' attributes, should be default size
PASS 'poster' but no 'src', should be 'poster' size
FAIL 'poster' and 'src', should be 'poster' size before play assert_equals: expected 76 but got 320 <---- fails
PASS 'poster' and 'src', should be 'video' size after play
PASS 'poster' and invalid 'src', should be 'poster' size
This test was added by above commit.
WebKit Source: https://searchfox.org/wubkat/rev/31a2e7171c54c5f7d395d7cf02ef0a8b5fca47d6/Source/WebCore/rendering/RenderVideo.cpp#119
It might be possible to fix the test by merging Blink patch but raising so we can track and fix it eventually.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/150975269>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/55994
EWS
Committed 305281@main (91c550440fa8): <https://commits.webkit.org/305281@main>
Reviewed commits have been landed. Closing PR #55994 and removing active labels.