Bug 292299
| Summary: | WebChromeClient::page() should return a raw pointer instead of a reference | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
WebChromeClient::page() should return a raw pointer instead of a reference since it can return a null pointer. So far, we've spot-fixed null -dereference crashes but we should address the situation more generally by returning a raw pointer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/44712
EWS
Committed 294312@main (47438b5caa88): <https://commits.webkit.org/294312@main>
Reviewed commits have been landed. Closing PR #44712 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/150331491>