Bug 292282
| Summary: | Modifying InFilesCompiler.pm doesn't trigger rebuild of EventTargetInterfaces.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | New Bugs | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | emw, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
In https://github.com/WebKit/WebKit/pull/44662, I had to modify EventTargetFactory.in to trigger rebuild of EventTargetInterfaces.h.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
I'm not an expert on IDL generation, but `InFilesCompiler.pm` probably needs to be added to the Makefile here: https://github.com/WebKit/WebKit/blob/982f2bf3cbd53a106acd1e55ffb23fc4b61864ef/Source/WebCore/DerivedSources.make#L2502-L2506
Ryosuke Niwa
Hm... probably more around https://github.com/WebKit/WebKit/blob/982f2bf3cbd53a106acd1e55ffb23fc4b61864ef/Source/WebCore/DerivedSources.make#L2352 ?
Radar WebKit Bug Importer
<rdar://problem/150298407>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/44697
EWS
Committed 294300@main (b33e7e2934b0): <https://commits.webkit.org/294300@main>
Reviewed commits have been landed. Closing PR #44697 and removing active labels.