Bug 29227

Summary: Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: Layout and RenderingAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.6   
Bug Depends on:    
Bug Blocks: 29228    
Attachments:
Description Flags
Some clean-up in RenderWidget
mitz: review+
The fix mitz: review+

Mark Rowe (bdash)
Reported 2009-09-12 18:33:07 PDT
Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000000005e8 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00007fff86f17e72 WebCore::RenderPart::setWidget(WebCore::Widget*) + 82 1 com.apple.WebCore 0x00007fff86fd170f WebCore::FrameLoader::loadPlugin(WebCore::RenderPart*, WebCore::KURL const&, WebCore::String const&, WTF::Vector<WebCore::String, 0ul> const&, WTF::Vector<WebCore::String, 0ul> const&, bool) + 495 2 com.apple.WebCore 0x00007fff86fd12db WebCore::FrameLoader::requestObject(WebCore::RenderPart*, WebCore::String const&, WebCore::AtomicString const&, WebCore::String const&, WTF::Vector<WebCore::String, 0ul> const&, WTF::Vector<WebCore::String, 0ul> const&) + 619 3 com.apple.WebCore 0x00007fff86f1a193 WebCore::RenderPartObject::updateWidget(bool) + 3667 4 com.apple.WebCore 0x00007fff86e73a15 WebCore::FrameView::updateWidgets() + 293 5 com.apple.WebCore 0x00007fff86e73659 WebCore::FrameView::performPostLayoutTasks() + 89 6 com.apple.WebCore 0x00007fff86e4cd85 WebCore::FrameView::layout(bool) + 1413
Attachments
Some clean-up in RenderWidget (5.65 KB, patch)
2009-09-12 18:36 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
The fix (3.19 KB, patch)
2009-09-12 18:37 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-09-12 18:35:06 PDT
<rdar://problem/6954546>
Mark Rowe (bdash)
Comment 2 2009-09-12 18:36:37 PDT
Created attachment 39521 [details] Some clean-up in RenderWidget This makes the fix for the crash much cleaner.
Mark Rowe (bdash)
Comment 3 2009-09-12 18:37:48 PDT
Created attachment 39522 [details] The fix The test will be added when bug 29228 is fixed.
Mark Rowe (bdash)
Comment 4 2009-09-14 11:12:35 PDT
Landed in r48358 and r48359.
Note You need to log in before you can comment on or make changes to this bug.