Summary: | Compile KeyframeList.cpp and AnimationBase.cpp in winscw compiler. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> | ||||
Component: | WebCore Misc. | Assignee: | Yongjun Zhang <yongjun.zhang> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | kling, laszlo.gombos | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | S60 Emulator | ||||||
OS: | S60 3rd edition | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 27065 | ||||||
Attachments: |
|
Description
Yongjun Zhang
2009-09-11 12:34:04 PDT
sorry, the comment url should be: https://bugs.webkit.org/show_bug.cgi?id=28054#c15 and https://bugs.webkit.org/show_bug.cgi?id=28054#c17 Created attachment 39472 [details]
Move setAnimation() and KeyframeList() ctor to respective cpp files.
Comment on attachment 39472 [details]
Move setAnimation() and KeyframeList() ctor to respective cpp files.
Why are these changes needed? And why are we supporting this broken compiler... ;) The number of fixes needed to make winscw work seems to be growing without bound.
r-. We need more explanation for each of these (seemingly arbitrary) changes, and ideally links to compiler bugs you've filed with the winscw folks.
(In reply to comment #3) > (From update of attachment 39472 [details]) Thanks a lot for the comment, Eric. > Why are these changes needed? And why are we supporting this broken compiler... Winscw compiler (based on Codewarrior) is used in building apps running in S60 emulator, so far that is the only available emulator compiler for us :-( > ;) The number of fixes needed to make winscw work seems to be growing without > bound. We fully understand the concern; and we tried hard to make sure the changes are minimum and really necessary. Good news is all the winscw patches are submitted for review and looks like there won't be any further patches for this issue any more. > r-. We need more explanation for each of these (seemingly arbitrary) changes, > and ideally links to compiler bugs you've filed with the winscw folks. There is a bug for it in winscw compiler bugzilla (https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812). It is essentially the same issue as https://bugs.webkit.org/show_bug?id=28054 except it is caused by ref(), not deref(). WinSCW support is no longer an issue as Symbian support has been removed from WebKit trunk. |