Bug 29194

Summary:

Shift + Mousewheel should go back/forward to match other browsers on Windows

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

WebKit Misc.

Assignee:

Brian Weinstein <bweinstein>

Status:

ASSIGNED

Severity:

Normal

CC:

aroben, hyatt

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Fix	aroben: review-, bweinstein: commit-queue-
Fix + Tests	bweinstein: commit-queue-
Fix + Test + Fixed wrong test commends	abarth: review-, bweinstein: commit-queue-

Brian Weinstein

Reported 2009-09-11 10:49:11 PDT

IE, Firefox, and Opera all do this on Windows, meaning we probably should too.

Attachments
Fix (1.97 KB, patch) 2009-09-11 11:01 PDT, Brian Weinstein	aroben: review- bweinstein: commit-queue-	Details Formatted Diff Diff
Fix + Tests (12.85 KB, patch) 2009-09-14 13:02 PDT, Brian Weinstein	bweinstein: commit-queue-	Details Formatted Diff Diff
Fix + Test + Fixed wrong test commends (12.65 KB, patch) 2009-09-14 13:04 PDT, Brian Weinstein	abarth: review- bweinstein: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2009-09-11 11:01:18 PDT

Created attachment 39451 [details] Fix

Adam Roben (:aroben)

Comment 2 2009-09-11 11:07:08 PDT

We currently use Shift+mousewheel to do horizontal scrolling. I wonder which behavior is more important? Maybe Hyatt has an opinion.

Adam Roben (:aroben)

Comment 3 2009-09-11 11:11:05 PDT

Comment on attachment 39451 [details] Fix The code change looks fine. Can we make a regression test that shows that these events go back/forward, and that they don't make it down into the DOM?

Brian Weinstein

Comment 4 2009-09-14 13:02:07 PDT

Created attachment 39568 [details] Fix + Tests

Brian Weinstein

Comment 5 2009-09-14 13:04:27 PDT

Created attachment 39569 [details] Fix + Test + Fixed wrong test commends

Adam Barth

Comment 6 2009-09-23 22:31:04 PDT

Comment on attachment 39569 [details] Fix + Test + Fixed wrong test commends What about Ctrl+Shift? Is back/forward the right behavior there? What if the Alt modifier is present as well? In general, we probably want much tighter checks of the modifier keys.

Brian Weinstein

Comment 7 2009-09-23 23:03:54 PDT

That's a good point. I don't know what control + shift should do. I will do check on the other browsers and write an updated comment + ChangeLog entry with my findings/update the patch if necessary.

Note You need to log in before you can comment on or make changes to this bug.