Bug 291916 – REGRESSION (292627@main): Doubled text on maps.google.com

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Matt Woodrow]

1. Open https://www.google.com/maps/place/Cannings+Free+Range+Butchers+South+Yarra/@-37.8373171,144.6918945,11z/data=!3m1!5s0x6a948ac76fd9f0f1:0xe5727d014f06d80e!4m12!1m2!2m1!1sCannings+Free+Range+Butchers!3m8!1s0x6ad64283633f1f3b:0x982cab9272bbd434!8m2!3d-37.8373171!4d144.9967651!9m1!1b1!15sChxDYW5uaW5ncyBGcmVlIFJhbmdlIEJ1dGNoZXJzIgOIAQGSAQxidXRjaGVyX3Nob3DgAQA!16s%2Fg%2F11c6w18cw_
2. Click the “About” tab of the place card.
3. Click the “Reviews” tab of the place card.
4. Notice that once the reviews load, the overall review score, stars, and text below it are doubled.

[Matt Woodrow]

Created attachment 475014 [details]
Testcase

Reduced test case:

Has a composited layer that requires a backing store (that can’t be optimised away to a color).
Scroller with overflow:auto inside, forcing non-overlay scrollbars and initially no overflow (which makes the layer not-self-painting).
Change to an inner element that adds overflow to the scroller.


The new overflow causes RenderLayerScrollableArea::computeHasCompositedScrollableOverflow to determine that we need a compositing layer (and also implicitly makes the layer self painting).

This calls RenderLayerCompositor::layerGainedCompositedScrollableOverflow to repaint the relevant pixels that will no longer be occupied by the scroller. The cached repaint container is nullptr (not-self-painting layers don’t have one), so this repaint targets the RenderView. That’s incorrect, and we leave the dirty pixels in the outer layer but also draw them into the scroller’s layer (offset slightly, due to the presence of the scrollbar).

This regressed because previously we recomputed the repaint container each time, and did so in the intermediate state between making the layer self painting, and applying the compositing change, so the ‘right’ one was computed.

[Matt Woodrow]

<rdar://149594692>

[Matt Woodrow]

Pull request: https://github.com/WebKit/WebKit/pull/44388

[EWS]

Committed 294225@main (0d37fd4f8a3e): <https://commits.webkit.org/294225@main>

Reviewed commits have been landed. Closing PR #44388 and removing active labels.