Bug 29146

Summary: stdint and stdbool should check for msvc compiler and not the windows platform
Product: WebKit Reporter: Benjamin Meyer <ben>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
eric: review-
patch + updated error and comment none

Benjamin Meyer
Reported 2009-09-10 13:38:53 PDT
Created attachment 39372 [details] patch The webkit stdint and stdbool headers exists because the compiler MSVC doesn't include them. The check should not check for PLATFORM(WIN_OS) but for MSVC.
Attachments
patch (2.11 KB, patch)
2009-09-10 13:38 PDT, Benjamin Meyer 		eric: review-
DetailsFormatted DiffDiff
patch + updated error and comment (2.47 KB, patch)
2009-09-11 07:55 PDT, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-10 17:49:10 PDT
Comment on attachment 39372 [details] patch Seems we need to change the #error then too, no?
Benjamin Meyer
Comment 2 2009-09-11 07:55:24 PDT
Created attachment 39433 [details] patch + updated error and comment Good call, I have updated the #error and the comment in stdint.h to match the behavior and provide more detail.
Eric Seidel (no email)
Comment 3 2009-09-15 23:10:54 PDT
Comment on attachment 39433 [details] patch + updated error and comment Looks sane enough to me. Since it doesn't look like you're a committer yet (http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py) adding this to the commit-queue on your behalf.
WebKit Commit Bot
Comment 4 2009-09-16 12:30:02 PDT
Comment on attachment 39433 [details] patch + updated error and comment Clearing flags on attachment: 39433 Committed r48427: <http://trac.webkit.org/changeset/48427>
WebKit Commit Bot
Comment 5 2009-09-16 12:30:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.