Bug 29139

Summary: Add variant to WebGL uniform* and vertexAttrib* calls
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
oliver: review-
Replacement patch oliver: review+

Chris Marrin
Reported 2009-09-10 12:07:14 PDT
We've decided to add a variant which takes a JS array in place of the CanvasXXXArray to all the uniform, uniformMatrix and vertexAttrib functions of CanvasRenderingContext3D.
Attachments
Patch (43.43 KB, patch)
2009-09-11 15:50 PDT, Chris Marrin 		oliver: review-
DetailsFormatted DiffDiff
Replacement patch (48.35 KB, patch)
2009-09-11 16:44 PDT, Chris Marrin 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2009-09-11 15:50:19 PDT
Created attachment 39484 [details] Patch
Oliver Hunt
Comment 2 2009-09-11 15:58:58 PDT
Comment on attachment 39484 [details] Patch I don't like the many examples of code like "static_cast<float*>(v->baseAddress())" -- i would prefer CanvasFooArray all have a Foo* data() const { return stati_cast<Foo*>(baseAddress()); } methods that you would use instead.
Chris Marrin
Comment 3 2009-09-11 16:44:17 PDT
Created attachment 39492 [details] Replacement patch
Chris Marrin
Comment 4 2009-09-11 17:14:05 PDT
Sending WebCore/ChangeLog Sending WebCore/bindings/js/JSCanvasRenderingContext3DCustom.cpp Sending WebCore/html/canvas/CanvasByteArray.h Sending WebCore/html/canvas/CanvasFloatArray.h Sending WebCore/html/canvas/CanvasIntArray.h Sending WebCore/html/canvas/CanvasRenderingContext3D.cpp Sending WebCore/html/canvas/CanvasRenderingContext3D.h Sending WebCore/html/canvas/CanvasRenderingContext3D.idl Sending WebCore/html/canvas/CanvasShortArray.h Sending WebCore/html/canvas/CanvasUnsignedByteArray.h Sending WebCore/html/canvas/CanvasUnsignedIntArray.h Sending WebCore/html/canvas/CanvasUnsignedShortArray.h Sending WebCore/platform/graphics/GraphicsContext3D.h Sending WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp Transmitting file data .............. Committed revision 48325.
Note You need to log in before you can comment on or make changes to this bug.