Bug 29128 – User style/ script injection API for WebKitGTK+

• Component: WebKitGTK
• Status: RESOLVED WONTFIX

[Christian Dywan]

See the recent changeset http://trac.webkit.org/changeset/48222 .

I'd like to have API to inject a style or script into a WebKitWebView.

[Jan Alonzo]

Created attachment 39919 [details]
WIP patch

This is somewhat final patch. The issue I have is that I get a console message whenever I ran the stylesheet injection test. 

Feedback and suggestions welcome.

[Christian Dywan]

From looking at the API, I'm wondering about group and world ID. The naming feels a bit odd to me. It makes me wonder, what kind of group is that and what is a "world" in this context? The group is the same as a page group apparently (which we don't expose currently) and "world" is a different kind of group. Is this API actually tied to the web view, or is it global?

I'm testing this in Midori now and will come back with more feedback.

[Christian Dywan]

So after testing, I found out:
- The group name *has* to be equal to the group of the web view, otherwise the script or stylesheet is ignored.
- The URI argument is not functional, I *have* to pass the source. I would expect it to load the file for me if I don't provide the source.
- I don't know what pattern is good for, the test isn't using it either.

I suggest the API is changed in one of two ways:
- We invent a WebKitPageGroup object and put the user script functions on it.
- We leave the group_name argument out and apply it behind the scenes - probably confusing to new developers.

[Christian Dywan]

I uploaded a new patch to bug 32789 for the WebKitWebGroup API.

[Martin Robinson]

The GTK+ port of WebKit1 has been removed.