Bug 291169

Summary: [GTK][WPE] Build fails with ENABLE_RESOURCE_USAGE=OFF
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebCore Misc.Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Adrian Perez
Reported 2025-04-06 14:55:54 PDT
We have this in Options{GTK,WPE}.cmake: if (CMAKE_SYSTEM_NAME MATCHES "Linux") WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON) else () WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF) endif () The main case in which we need to support building with ENABLE_RESOURCE_USAGE=OFF is when WPE is built targeting Android, which currently will produce the following build error: /home/aperez/wpe/cerbero/build/sources/android_arm64/wpewebkit-2.48.1/Source/WebCore/page/Page.cpp:542:39: error: use of undeclared identifier 'm_resourceUsageOverlay' 542 | if (RefPtr resourceUsageOverlay = m_resourceUsageOverlay) | ^
Attachments
EWS
Comment 1 2025-04-06 15:08:46 PDT
Committed 293334@main (fcd08c3163d8): <https://commits.webkit.org/293334@main> Reviewed commits have been landed. Closing PR #43718 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2025-04-06 15:09:23 PDT
Note You need to log in before you can comment on or make changes to this bug.