Bug 291116
| Summary: | Remove unnecessary ObjC object instantiation in JavaScriptEvaluationResult conversion to JSValueRef | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | Morningstar, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alex Christensen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/148630517>
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/43672
EWS
Committed 297138@main (90da1bac176f): <https://commits.webkit.org/297138@main>
Reviewed commits have been landed. Closing PR #43672 and removing active labels.
Dawn Morningstar
This looks like it broke 500+ api tests in debug https://results.webkit.org/suites?suite=api-tests
Crash is: JavaScript execution returned a result of an unsupported type\" UserInfo={NSLocalizedDescription=JavaScript execution returned a result of an unsupported type} while evaluating script: document.execCommand('selectAll', false, null)
Ryan Haddad
This commit was reverted in https://commits.webkit.org/297183@main. Reopening.