Bug 290878
| Summary: | Use mach_vm_map and copy instead of mach_vm_remap in setPermissionsOfConfigPage | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | Web Template Framework | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=290066 | ||
David Degazio
In https://bugs.webkit.org/show_bug.cgi?id=290066 we switched away from mach_vm_map to using mach_vm_remap when setting up permissions of the g_config pages in order to avoid wiping out any pre-WTF config data. It turns out mach_vm_remap has limited support on Apple platforms other than macOS, so it's safer to continue using mach_vm_map and, since the pre-WTF portion of the config is a fairly small and bounded amount of memory, copy the memory to a side buffer then copy it back in once we've set up the correct permissions.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/148377519>
David Degazio
rdar://148277754
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/43424
EWS
Committed 293128@main (4e67c38f20d9): <https://commits.webkit.org/293128@main>
Reviewed commits have been landed. Closing PR #43424 and removing active labels.
EWS
Committed 289651.403@safari-7621-branch (4205ada8dd5d): <https://commits.webkit.org/289651.403@safari-7621-branch>
Reviewed commits have been landed. Closing PR #2968 and removing active labels.