Bug 290598
Summary: | Define an accurate list of aliases for each autoinstalled package | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=291902 |
Sam Sneddon [:gsnedders]
We've been having various systems fail like:
```
File "/Volumes/Data/sample.py", line 4, in <module>
from attrs import define, field, evolve
File "/Library/Python/3.9/site-packages/attrs/__init__.py", line 3, in <module>
from attr import (
ImportError: cannot import name 'AttrsInstance' from 'attr' (/Users/buildbot/Library/webkitpy/autoinstalled/python-3-arm64/attr/__init__.py)
```
This is ultimately because we define:
```
AutoInstall.install(Package('attr', Version(21, 3, 0), pypi_name='attrs'))
```
This results in the autoinstaller not knowing that `attrs` release also provides an `attrs` module, thus it doesn't get auto-installed till the system-installed `attrs` is trying to import it… and then we're dealing with multiple incompatible versions, because why would you have an `attrs` module from version 25.3.0 and an `atto` module from version 21.3.0.
For things we're installing with wheels we can look in the distribution to find out what's in it, and warn if they differ, though that is maybe future work.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/43164
Radar WebKit Bug Importer
<rdar://problem/148072355>
EWS
Committed 292966@main (082fbf947bdf): <https://commits.webkit.org/292966@main>
Reviewed commits have been landed. Closing PR #43164 and removing active labels.