Bug 290251

Summary: [JSC] `DEFINE_VISIT_AGGREGATE` for `StringReplaceaCache` should be used in source file
Product: WebKit Reporter: Sosuke Suzuki <sosuke>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Sosuke Suzuki
Reported 2025-03-22 03:37:18 PDT
`DEFINE_VISIT_AGGREGATE` defines not-ininlined functions[1], so it should be used in source file. However, it is used in `StringReplaceCacheInlines.h`. This patch fixes it. [1]: https://github.com/WebKit/WebKit/blob/b12ed39572951123a4b5a99c471e0262e9481001/Source/JavaScriptCore/heap/SlotVisitorMacros.h#L54-L60
Attachments
Add attachment proposed patch, testcase, etc.
Sosuke Suzuki
Comment 1 2025-03-22 03:38:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/42876
EWS
Comment 2 2025-03-22 22:35:44 PDT
Committed 292554@main (8461269197eb): <https://commits.webkit.org/292554@main> Reviewed commits have been landed. Closing PR #42876 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2025-03-22 22:36:14 PDT
<rdar://problem/147677033>
Note You need to log in before you can comment on or make changes to this bug.