Bug 290098

Summary:	[GTK][WPE] Remove invalid flag from Damage
Product:	WebKit	Reporter:	Carlos Garcia Campos <cgarcia>
Component:	Platform	Assignee:	Carlos Garcia Campos <cgarcia>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Carlos Garcia Campos

Reported 2025-03-20 06:42:41 PDT

The invalid flag is very confusing, it's not clear the difference between empty and invalid Damage, and it's used with different meanings in different places. We can just use std::optional which always means no damage, so that the way we handle no damage depends on every case.

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2025-03-20 06:53:23 PDT

Pull request: https://github.com/WebKit/WebKit/pull/42743

EWS

Comment 2 2025-03-20 09:55:38 PDT

Committed 292420@main (f84fa6a88b80): <https://commits.webkit.org/292420@main> Reviewed commits have been landed. Closing PR #42743 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2025-03-20 09:56:14 PDT

<rdar://problem/147504711>

Note You need to log in before you can comment on or make changes to this bug.