Bug 28996

Summary:

[Qt] r47424 broke binary compatibility

Product:

WebKit

Reporter:

Jakub Wieczorek <jwieczorek>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Restore the binary compatibility with 4.5.	none

Jakub Wieczorek

Reported 2009-09-05 06:48:29 PDT

http://trac.webkit.org/changeset/47424 The new attribute should have been appended at the end of the enumerator list to keep the other values unchanged.

Attachments
Restore the binary compatibility with 4.5. (1.63 KB, patch) 2009-09-05 06:52 PDT, Jakub Wieczorek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jakub Wieczorek

Comment 1 2009-09-05 06:52:03 PDT

Created attachment 39116 [details] Restore the binary compatibility with 4.5.

Eric Seidel (no email)

Comment 2 2009-09-05 16:27:46 PDT

Comment on attachment 39116 [details] Restore the binary compatibility with 4.5. Seems you all would want a comment at the top of this enum to indicated why they're not sorted. But OK.

Eric Seidel (no email)

Comment 3 2009-09-05 16:47:48 PDT

Comment on attachment 39116 [details] Restore the binary compatibility with 4.5. Clearing flags on attachment: 39116 Committed r48097: <http://trac.webkit.org/changeset/48097>

Eric Seidel (no email)

Comment 4 2009-09-05 16:47:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.