Bug 289933 – [JSC] Fix Clang 20 warnings

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Fujii Hironori]

[1299/7125] Generating ../../WebCore/DerivedSources/CSSProperties.json, ../../WebCore/DerivedSources/CSSPrope...urces/StylePropertyShorthandFunctions.cpp, ../../WebCore/DerivedSources/CSSStyleDeclaration+PropertyNames.id
1 input keys have identical hash values, examine output carefully...
[1438/7125] Building CXX object Tools\TestWebKitAPI\CMakeFiles\TestWTF.dir\Tests\WTF\StringView.cpp.obj
C:\webkit\wb\Tools\TestWebKitAPI\Tests\WTF\StringView.cpp(87,35): warning: temporary whose address is used as value of local variable 'viewWithCharacters' will be destroyed at the end of the full-expression [-Wdangling]
   87 |     StringView viewWithCharacters(String("hello"_s));
      |                                   ^~~~~~~~~~~~~~~~~
1 warning generated.
[1582/7125] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-cd2e8cfa-1.cpp.obj
In file included from C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-cd2e8cfa-1.cpp:6:
In file included from C:\webkit\wb\Source\JavaScriptCore\assembler/LinkBuffer.cpp:27:
C:\webkit\wb\Source\JavaScriptCore\assembler\LinkBuffer.h(392,11): warning: private field 'm_ownerUID' is not used [-Wunused-private-field]
  392 |     void* m_ownerUID { nullptr };
      |           ^
C:\webkit\wb\Source\JavaScriptCore\assembler\LinkBuffer.h(409,10): warning: private field 'm_isRewriting' is not used [-Wunused-private-field]
  409 |     bool m_isRewriting { false };
      |          ^
2 warnings generated.
[1626/7125] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-bfc896e1-5.cpp.obj
In file included from C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-bfc896e1-5.cpp:1:
In file included from C:\webkit\wb\Source\JavaScriptCore\dfg/DFGConstantHoistingPhase.cpp:31:
In file included from C:\webkit\wb\Source\JavaScriptCore\dfg\DFGGraph.h:37:
In file included from C:\webkit\wb\Source\JavaScriptCore\dfg\DFGPlan.h:33:
C:\webkit\wb\Source\JavaScriptCore\dfg\DFGDesiredWeakReferences.h(63,16): warning: private field 'm_codeBlock' is not used [-Wunused-private-field]
   63 |     CodeBlock* m_codeBlock;
      |                ^
1 warning generated.
[1677/7125] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-3a3c4ec0-6.cpp.obj
In file included from C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-3a3c4ec0-6.cpp:3:
In file included from C:\webkit\wb\Source\JavaScriptCore\jit/JITSafepoint.cpp:27:
C:\webkit\wb\Source\JavaScriptCore\jit\JITSafepoint.h(57,14): warning: private field 'm_keepDependenciesLive' is not used [-Wunused-private-field]
   57 |         bool m_keepDependenciesLive;
      |              ^
1 warning generated.
[1683/7125] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-f2e18ffc-10.cpp.obj
In file included from C:\webkit\wb\WebKitBuild\Debug\JavaScriptCore\DerivedSources\unified-sources\UnifiedSource-f2e18ffc-10.cpp:5:
C:\webkit\wb\Source\JavaScriptCore\runtime/ExceptionHelpers.cpp(119,16): warning: returning address of local temporary object [-Wreturn-stack-address]
  119 |         return String();
      |                ^~~~~~~~
C:\webkit\wb\Source\JavaScriptCore\runtime/ExceptionHelpers.cpp(152,16): warning: returning address of local temporary object [-Wreturn-stack-address]
  152 |         return String();
      |                ^~~~~~~~
2 warnings generated.

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/42598

[Fujii Hironori]

one more warning in release build.

In file included from C:\webkit\wb\Source\JavaScriptCore\bytecode\InlineCacheCompiler.cpp:27:
C:\webkit\wb\Source\JavaScriptCore\bytecode\InlineCacheCompiler.h(434,13): error: private field 'm_jitType' is not used [-Werror,-Wunused-private-field]
  434 |     JITType m_jitType;
      |             ^
1 error generated.

[EWS]

Committed 292393@main (2a4b0488dd38): <https://commits.webkit.org/292393@main>

Reviewed commits have been landed. Closing PR #42598 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/147460275>