Bug 28987

Summary: Make the Document cache the Page's user stylesheet in parsed form
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: solushex
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Dave Hyatt
Reported 2009-09-04 15:31:08 PDT
This is just a minor optimization to ensure we don't reparse the user stylesheet just because the CSSStyleSelector went away (which can happen if you add/remove sheets or for some other reasons).
Attachments
Patch (8.11 KB, patch)
2009-09-04 15:32 PDT, Dave Hyatt 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2009-09-04 15:32:32 PDT
Created attachment 39092 [details] Patch
Eric Seidel (no email)
Comment 2 2009-09-05 16:31:22 PDT
Comment on attachment 39092 [details] Patch OK. r+, cq-. Hyatt can set cq+ himself if he wants the bot to land this for him.
Dave Hyatt
Comment 3 2009-09-08 13:27:11 PDT
Fixed in r48181.
rahul abrol
Comment 4 2009-10-12 20:54:55 PDT
this fix broke simple selectors in my user stylesheet. #someId and div#someId are no longer recognized; i have to use div[id="someId"]. i'm using tiger on PPC if it matters.
Note You need to log in before you can comment on or make changes to this bug.