Bug 289834
| Summary: | platform-enabled-swift-args.resp introduces a WTF:installhdrs dependency on WebKitAdditions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
Because WTF generates the response file during installhdrs, and Platform*.h conditionally includes WebKitAdditions headers using __has_include, the contents of the .resp file will be nondeterministic. We either need to modify the internal build to ensure WebKitAdditions and WTF build in order, or refactor how we generate the .resp file.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
<rdar://problem/147082710>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/42520
EWS
Committed 292201@main (ca5726399ac9): <https://commits.webkit.org/292201@main>
Reviewed commits have been landed. Closing PR #42520 and removing active labels.