Bug 289606
| Summary: | Build failure with libsoup < 2.70 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Gorse <mgorse> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
Mike Gorse
After R289693, the build fails with libsoup 2.68 and older:
../Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp: In function ‘std::optional<std::unique_ptr<_GSList, WebCore::Deleter<_GSList, soup_cookies_free> > > WebCore::lookupCookies(const NetworkStorageSession&, const WTF::URL&, const SameSiteInfo&, const WTF::URL&, ForHTTPHeader, std::optional<ProcessQualified<WTF::ObjectIdentifierGeneric<FrameIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<long unsigned int>, long unsigned int> > >, std::optional<WTF::ObjectIdentifierGeneric<PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<long unsigned int>, long unsigned int> >, ApplyTrackingPrevention, ShouldRelaxThirdPartyCookieBlocking, IncludeSecureCookies, bool*)’:
../Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:676:56: error: ‘cookieStorage’ was not declared in this scope
676 | CookieList cookies(soup_cookie_jar_get_cookie_list(cookieStorage(), uri.get(), forHTTPHeader == ForHTTPHeader::Yes));
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mike Gorse
Pull request: https://github.com/WebKit/WebKit/pull/42317
EWS
Committed 292021@main (5c50df94bd2a): <https://commits.webkit.org/292021@main>
Reviewed commits have been landed. Closing PR #42317 and removing active labels.