Bug 289555
| Summary: | [Grid][Cleanup] Adopt RenderChildIterator throughout grid code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
RenderGrid has a few instances of a common pattern that is used to traverse over its grid items:
for (RenderBox* gridItem = firstChildBox(); gridItem; gridItem = gridItem->nextSiblingBox())
If we started adopting RenderChildIterator in these places to do the same thing we could use range based for loops instead which is a nice cleanup
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146779702>
Taher
Pull request: https://github.com/WebKit/WebKit/pull/42277
EWS
Committed 292043@main (f0515d83ab79): <https://commits.webkit.org/292043@main>
Reviewed commits have been landed. Closing PR #42277 and removing active labels.