Bug 289485
| Summary: | [EWS] merge-queue build was marked as successful even though the `push-pull-request-branch` step failed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, bfan2, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Haddad
In https://ews-build.webkit.org/#/builders/19/builds/19842, the `push-pull-request-branch` step failed but the overall build was marked as successful with the status text "Passed layout tests". This caused the green checkmark to appear on the EWS status comment, but the change wasn't actually merged.
If the `push-pull-request-branch` step fails, we should make sure to flunk the build.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146684509>
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/46090
EWS
Committed 295615@main (fd7584e82b03): <https://commits.webkit.org/295615@main>
Reviewed commits have been landed. Closing PR #46090 and removing active labels.