Summary: | ASSERT executing the webhistory unittest in a debug build | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Xan Lopez
2009-09-03 07:27:02 PDT
This was touched recently in r47911, which claimed to be also fixing a possible ASSERT in debug builds. Mmmm :) Created attachment 40701 [details]
Patch fixing the problem
The problem was caused because webkit_init was not called before the instantiation of a KURL. Apparently webkit_init is being called in the class_init but it is not enough in these cases. If we want a more general solution we can check all the places that could cause a problem like this or comment that webkit_init should be called by the programs before doing anything (but this would mean adding the function to the API if it is not). Anyway we have to consider that if someone uses webkit library and tries to create a KURL is going to have problems if they do not call webkit_init in advance calling other API functions.
(In reply to comment #2) > Created an attachment (id=40701) [details] > Patch fixing the problem > > The problem was caused because webkit_init was not called before the > instantiation of a KURL. Apparently webkit_init is being called in the > class_init but it is not enough in these cases. If we want a more general > solution we can check all the places that could cause a problem like this or > comment that webkit_init should be called by the programs before doing anything > (but this would mean adding the function to the API if it is not). Anyway we > have to consider that if someone uses webkit library and tries to create a KURL > is going to have problems if they do not call webkit_init in advance calling > other API functions. Keep in mind that KURL and everything else in WebCore is not public API, so that is not a problem. The problem is that we might have lots of other functions where calls to WebCore are made before any class_init is called, which as shown in this test can cause problems. Created attachment 40702 [details]
Fixed Changelog style
Sorry about that :)
Comment on attachment 40702 [details]
Fixed Changelog style
r=me, thanks!
Comment on attachment 40702 [details] Fixed Changelog style Clearing flags on attachment: 40702 Committed r49172: <http://trac.webkit.org/changeset/49172> All reviewed patches have been landed. Closing bug. |