Bug 289451

Summary:	Add missing dynamic_objc_cast<NSString>() when calling WTF::String constructor
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	New Bugs	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

David Kilzer (:ddkilzer)

Reported 2025-03-09 22:29:07 PDT

Add missing dynamic_objc_cast<NSString>() when calling WTF::String constructor. These were found when I temporarily added a WTF::String(xpc_object_t) constructor for Bug 288984, and then the WTF::String(NSString *) constructor became ambiguous. ggggggg

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2025-03-09 22:29:27 PDT

<rdar://problem/146632758>

David Kilzer (:ddkilzer)

Comment 2 2025-03-09 22:32:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/42181

EWS

Comment 3 2025-03-10 11:47:36 PDT

Committed 291902@main (94392ffe1a2a): <https://commits.webkit.org/291902@main> Reviewed commits have been landed. Closing PR #42181 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.