Bug 289440
| Summary: | Add ReflectSetter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | DOM | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Darin Adler
Add ReflectSetter
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146613724>
Darin Adler
Pull request: https://github.com/WebKit/WebKit/pull/45901
EWS
Committed 296427@main (4c99b6a9d25c): <https://commits.webkit.org/296427@main>
Reviewed commits have been landed. Closing PR #45901 and removing active labels.
Diego Pino
After this change, GTK3 build bot is failing with the following build error:
https://build.webkit.org/#/builders/1519/builds/5012/steps/10/logs/stdio
```
/buildbot-worker/work/GTK-Linux-64-bit-Release-GTK3-Build/build/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBaseElement.cpp:187:11: error: ‘class WebCore::HTMLBaseElement’ has no member named ‘setHref’; did you mean ‘setPrefix’?
187 | item->setHref(WTF::AtomString::fromUTF8(value));
| ^~~~~~~
| setPrefix
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/47302
EWS
Committed 296732@main (bbbf39e5eddd): <https://commits.webkit.org/296732@main>
Reviewed commits have been landed. Closing PR #47302 and removing active labels.
Darin Adler
(In reply to Diego Pino from comment #4)
> After this change, GTK3 build bot is failing with the following build error
Why didn’t the EWS show this failure? I rely on that to make sure I don’t break GTK builds.
Diego Pino
(In reply to Darin Adler from comment #7)
> (In reply to Diego Pino from comment #4)
> > After this change, GTK3 build bot is failing with the following build error
>
> Why didn’t the EWS show this failure? I rely on that to make sure I don’t
> break GTK builds.
It's because the EWS GTK build bot builds with GTK4 which is now the default. Right now, there's not EWS GTK build bot for GTK3, only a post-commit bot.