Bug 289363
| Summary: | [HDR] Enable HDR display for CSS images | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=287985 | ||
| Bug Depends on: | |||
| Bug Blocks: | 282299 | ||
Said Abou-Hallawa
In 290804@main, HDR display was disabled completely for CSS images. The goal was to have consistent display for the same image regardless whether it is displayed inside an HDR layer or SDR layer. The performance of the render tree scanning was a concern also. Scanning all the CSS images in a layer will add cost for PLT.
This turned out to be incorrect approach. Many images are displayed through the CSS property background-image: url(...);. For example https://gregbenzphotography.com/hdr-gain-map-gallery/ will not display HDR content for all the HDR images because all of the images in the images are CSS images.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/146509866>
Radar WebKit Bug Importer
<rdar://problem/146510819>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/42362
Said Abou-Hallawa
*** Bug 288163 has been marked as a duplicate of this bug. ***
EWS
Committed 292305@main (c680aebea33b): <https://commits.webkit.org/292305@main>
Reviewed commits have been landed. Closing PR #42362 and removing active labels.