Bug 28929

Summary:

[HTML5] Support for HTMLTextAreaElement.textLength

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-textarea-textlength

Attachments:

Description	Flags
Proposed patch	tkent: review-
Proposed patch (rev.2)	none
Proposed patch (rev.3)	none
Proposed patch (rev.4)	eric: review+, eric: commit-queue-
Proposed patch (rev.5)	none

Kent Tamura

Reported 2009-09-02 17:56:31 PDT

Need to support for HTMLTextAreaElement.textLength. Corresponding Chromium issue: http://code.google.com/p/chromium/issues/detail?id=2435

Attachments
Proposed patch (3.37 KB, patch) 2009-09-02 19:27 PDT, Kent Tamura	tkent: review-	Details Formatted Diff Diff
Proposed patch (rev.2) (4.67 KB, patch) 2009-09-02 23:59 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Proposed patch (rev.3) (4.66 KB, patch) 2009-09-03 03:05 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Proposed patch (rev.4) (2.18 KB, patch) 2009-09-03 07:25 PDT, Kent Tamura	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
Proposed patch (rev.5) (4.63 KB, patch) 2009-09-03 18:32 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2009-09-02 19:27:45 PDT

Created attachment 38964 [details] Proposed patch run-webkit-tests and check-webkit-style passed.

Kent Tamura

Comment 2 2009-09-02 23:59:35 PDT

Created attachment 38968 [details] Proposed patch (rev.2) The previous patch didn't have LayoutTests/fast/forms/resources/textarea-textlength.js.

Eric Seidel (no email)

Comment 3 2009-09-03 01:51:37 PDT

I don't think we use "unsigned long" just "unsigned" in c++ code, but I can't remember which is used in idls.

Kent Tamura

Comment 4 2009-09-03 02:22:15 PDT

Hmm, it(In reply to comment #3) > I don't think we use "unsigned long" just "unsigned" in c++ code, but I can't > remember which is used in idls. HTMLInputElement.maxLength: unsigned long in HTML5 IDL long in WebKit IDL int in WebKit C++ HTMLInputElement.size: unsigned long in HTML5 IDL unsigned long in WebKit IDL int in WebKit C++ HTMLInputElement.selectionStart and selectionEnd, HTMLTextAreaElement.cols, rows, selectionStart, and selectionEnd: unsigned long in HTML5 IDL long in WebKit IDL int in WebKit C++ Hmm, it's confusing ;-( Anyway, int seems ok in C++ code.

Kent Tamura

Comment 5 2009-09-03 03:05:37 PDT

Created attachment 38978 [details] Proposed patch (rev.3) - Changed the type of textLength() in C++ code: unsigned long -> int

Eric Seidel (no email)

Comment 6 2009-09-03 04:13:39 PDT

That doesn't make sense to me. It seems the other callsites are wrong. if it's "unsigned" in the idl, making it signed in the c++ code seem wrong.

Kent Tamura

Comment 7 2009-09-03 06:01:40 PDT

(In reply to comment #6) > That doesn't make sense to me. It seems the other callsites are wrong. if > it's "unsigned" in the idl, making it signed in the c++ code seem wrong. I have checked modern code: DataGridColumnList.idl, FileList.idl, and HTMLVideoElement.idl. Their "unsigned long" IDL attributes are implemented as "unsigned". Ok, I'll change the patch to "unsgined."

Kent Tamura

Comment 8 2009-09-03 07:25:36 PDT

Created attachment 38988 [details] Proposed patch (rev.4) int -> unsigned

Eric Seidel (no email)

Comment 9 2009-09-03 15:53:59 PDT

Comment on attachment 38988 [details] Proposed patch (rev.4) LGTM. Eventually we need to straighten out the rest of the unsigned/int mismatches. :(

Eric Seidel (no email)

Comment 10 2009-09-03 16:04:47 PDT

Comment on attachment 38988 [details] Proposed patch (rev.4) Rejecting patch 38988 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1

Kent Tamura

Comment 11 2009-09-03 18:32:25 PDT

Created attachment 39028 [details] Proposed patch (rev.5) I don't know the reason of the commit-queue failure. Anyway, update the patch for the latest WebKit source, and confirmed run-webkit-tests passed.

Eric Seidel (no email)

Comment 12 2009-09-03 22:24:29 PDT

Comment on attachment 39028 [details] Proposed patch (rev.5) Clearing flags on attachment: 39028 Committed r48038: <http://trac.webkit.org/changeset/48038>

Eric Seidel (no email)

Comment 13 2009-09-03 22:24:33 PDT

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 14 2009-09-03 23:55:25 PDT

I also do not know the reason. I guess the build was broken but the bots hadn't noticed yet.

Note You need to log in before you can comment on or make changes to this bug.